cut option maria_role as it has nothing to do with roles #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This option was introduced in #189. To my knowledge, there is no difference between MySQL and MariaDB regarding roles or when you call a user by its name alone. Same for roles.
For instance:
So both in MySQL and MariaDB you can omit the host.
The
mysql_user
plugin defaults host tolocalhost
:host=dict(type='str', default='localhost')
So all functions will always receive a host. Maybe the option was used to bypass the default, 'localhost' and search for '%' instead of localhost ? This works because when you don't specify a host, MySQL and MariaDB will assume host is '%'.
But then, I don't get why the search for '%' is made by an option called
maria_role
.I removed this option and if all tests path, I propose the get rid of it.
Sometime we must know if we are in MySQL or MariaDB, like when parsing the return of
SHOW GRANTS FOR
. For those cases I added a new function to the module_utilsmysql.py
calledget_server_type()
.ISSUE TYPE
COMPONENT NAME